-
Notifications
You must be signed in to change notification settings - Fork 1k
Split Login and Register, enable OIDC Registration. #20287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
…te the login page to not break test. This could be optimized further
…rd fields and login buttons
…vider and push it tothe frontend
… testing with Custos/CILogon
…ocal accounts is disabled.
…n defined, push the user off to the configured registration.
…en clicking on login.
45dd95e
to
ffb8792
Compare
Thanks for these changes @uwwint !!! Will try out all the use cases you've added next! |
Hi @ahmedhamidawan do you need any help on setting up the Tests? |
Hey @uwwint 👋 ! Feel free to add/adjust tests, and make changes on top of mine if needed! Just make sure to lint the changes before you commit:
|
This change introduces the ability to configure OIDC registration endpoints. In order to achieve this functionality Login and Register need to be split. The new functionality will do the following:
Add enduser registration endpoint to oidc_backends.xml
Expose them in /api/configuration
Add a galaxy configuration option to disable local accounts
Change the frontend to:

a. Split Login / Registration into two buttons
b. In case only one OIDC provider is configured and local accounts are disabled, Login will redirect the user to the OIDC endpoint.

In case local accounts are enabled the behavior of previous galaxy is retained.
c) In case local accounts are disabled and one OIDC provider with end user registration endpoint exists register will redirect the user straight to the registration of the OIDC provider.
In case no OIDC provider with end user registration is configured and local accounts are disabled, or local registration is disabled in galaxy.yml, registration is not shown on the UI (as per current behavior)
If more than one OIDC provider with an endpoint are defined, or local accounts are enabled the Registration page will show all options.
How to test the changes?
(Select all options that apply)
In order to test oidc registration, or disabling local accounts manual testing is still required. The best way is to test the following:
License